[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date: Sat, 12 Dec 2009 11:07:54 +0100
From: Kay Sievers <kay.sievers@...y.org>
To: linux-fsdevel <linux-fsdevel@...r.kernel.org>,
linux-kernel <linux-kernel@...r.kernel.org>
Cc: Greg KH <greg@...ah.com>
Subject: Re: get_sb_single() - do not pass options twice
On Thu, Nov 5, 2009 at 23:28, Kay Sievers <kay.sievers@...y.org> wrote:
> From: Kay Sievers <kay.sievers@...y.org>
> Subject: vfs: get_sb_single() - do not pass options twice
>
> Filesystem code usually destroys the option buffer while
> parsing it, which leads to errors when the same buffer is
> passed twice. In case we fill a new superblock with the
> options, do not pass the options again to the remount()
> call.
Ping! Can someone please have a look and comment on that?
Something like this will now be needed for 2.6.33 to silent a warning.
Thanks,
Kay
> Cc: Greg KH <greg@...ah.com>
> Signed-off-by: Kay Sievers <kay.sievers@...y.org>
> ---
> fs/super.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> --- a/fs/super.c
> +++ b/fs/super.c
> @@ -900,6 +900,8 @@ int get_sb_single(struct file_system_typ
> deactivate_locked_super(s);
> return error;
> }
> + /* options usually get mangled and can only be parsed once */
> + data = NULL;
> s->s_flags |= MS_ACTIVE;
> }
> do_remount_sb(s, flags, data, 0);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists