linux-kernel - Re: suspect & tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 15 Dec 2009 14:11:33 +0100
From:	Clemens Ladisch <clemens@...isch.de>
To:	Jon Smirl <jonsmirl@...il.com>
CC:	Joe Perches <joe@...ches.com>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: suspect & tests

Joe Perches wrote:
> A grep for possibly misused & tests
> 	grep -rP --include=*.[ch] -n -e "[^\&]\&[\=]*\s*\!" *
> shows some possible cases where && should
> have been used instead:
> ...
> sound/soc/codecs/stac9766.c:233:		vra &= !0x04;

This looks like ~ should have been used.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/