linux-kernel - Re: [PATCH 0/5] use DECLARE_COMPLETION_ONSTACK for non-constant completion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 16 Dec 2009 23:14:50 +0800
From:	Américo Wang <xiyou.wangcong@...il.com>
To:	Yong Zhang <yong.zhang0@...il.com>
Cc:	linux-kernel@...r.kernel.org, peterz@...radead.org
Subject: Re: [PATCH 0/5] use DECLARE_COMPLETION_ONSTACK for non-constant
	completion

On Wed, Dec 16, 2009 at 10:35:56PM +0800, Yong Zhang wrote:
>The _ONSTACK variant should be used for on-stack completion,
>otherwise it will break lockdep.
>
>Yong Zhang (5):
> aha152x: use DECLARE_COMPLETION_ONSTACK for non-constant completion
> mISDN: use DECLARE_COMPLETION_ONSTACK for non-constant completion
> USB: use DECLARE_COMPLETION_ONSTACK for non-constant completion
> hwmon: use DECLARE_COMPLETION_ONSTACK for non-constant completion
> powerpc/iseries: use DECLARE_COMPLETION_ONSTACK for non-constant completion

These all look fine for me.

Reviewed-by: WANG Cong <xiyou.wangcong@...il.com>

For lockdep stuff, you should Cc Peter, adding him into Cc...

Thanks.


>
> arch/powerpc/platforms/iseries/viopath.c |    2 +-
> drivers/hwmon/ams/ams-pmu.c              |    4 ++--
> drivers/isdn/mISDN/l1oip_core.c          |    2 +-
> drivers/scsi/aha152x.c                   |    2 +-
> drivers/usb/gadget/fsl_qe_udc.c          |    2 +-
> drivers/usb/gadget/fsl_udc_core.c        |    2 +-
> drivers/usb/gadget/langwell_udc.c        |    2 +-
> 7 files changed, 8 insertions(+), 8 deletions(-)
>--
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@...r.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at  http://www.tux.org/lkml/

-- 
Live like a child, think like the god.
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/