linux-kernel - Re: [RFC, PATCH 1/4] cleanup elf_core_dump(): remove ELF_CORE_EXTRA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 16 Dec 2009 11:23:37 +0900 (JST)
From:	Daisuke HATAYAMA <d.hatayama@...fujitsu.com>
To:	xiyou.wangcong@...il.com
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	jdike@...toit.com, tony.luck@...el.com, mhiramat@...hat.com
Subject: Re: [RFC, PATCH 1/4] cleanup elf_core_dump(): remove
 ELF_CORE_EXTRA_* macro

> On Tue, Dec 15, 2009 at 10:41 AM, Daisuke HATAYAMA
> <d.hatayama@...fujitsu.com> wrote:
> > elf_core_dump() uses #ifdef and the corresponding macro for hiding
> > _multiline_ logics in functions. This patch removes #ifdef and
> > replaces ELF_CORE_EXTRA_* by corresponding functions. For
> > architectures not implemeonting ELF_CORE_EXTRA_*, we use weak
> > functions in order to reduce a range of modification.
> >
> > This cleanup is for my next patches, but I think this cleanup itself
> > is worth doing regardless of my firnal purpose.
> >
> > Signed-off-by: Daisuke HATAYAMA <d.hatayama@...fujitsu.com>
> 
> 
> Good patch! I like it!
> 
> Just one problem below.
> 
> 
> > --- /dev/null
> > +++ b/arch/um/sys-i386/elfcore.c
> > @@ -0,0 +1,78 @@
> > +#include <linux/elf.h>
> > +#include <linux/fs.h>
> > +#include <linux/mm.h>
> > +
> > +#include <asm/elf.h>
> > +
> > +static int dump_write(struct file *file, const void *addr, int nr)
> > +{
> > +       return file->f_op->write(file, addr, nr, &file->f_pos) == nr;
> > +}
> 
> We already have the same dump_write() in fs/binfmt_elf.c, can't we
> reuse it? e.g. moving it to a header and make it staic inline.

Thanks for you comment.

I understand what you say.

I think now I will move it to include/linux/elfcore.h.

> 
> Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/