linux-kernel - RE: [GIT PULL] XFS update for 2.6.33-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 16 Dec 2009 21:41:12 -0600
From:	"Alex Elder" <aelder@....com>
To:	"Dave Chinner" <david@...morbit.com>,
	"Randy Dunlap" <randy.dunlap@...cle.com>
Cc:	<torvalds@...ux-foundation.org>, <linux-kernel@...r.kernel.org>,
	<xfs@....sgi.com>, <akpm@...ux-foundation.org>
Subject: RE: [GIT PULL] XFS update for 2.6.33-rc1

Dave Chinner wrote:
> On Wed, Dec 16, 2009 at 01:55:12PM -0800, Randy Dunlap wrote:
>> On Wed, 16 Dec 2009 15:26:10 -0600 Alex Elder wrote:
>> 
>>> One more XFS update for -rc1, now that the new XFS tracing code has
>>> been committed.
>> 
>> Sorry if I have missed it, but have the printk format warnings
>> on i386 builds been fixed?
> 
> I don't see any here w/ gcc 4.3.4 x86-64 compiling i386 kernels....

I didn't get them either when I built in my environment.

Dave, your patch looks good to me, and Randy has acked it
so I'm going to pull it into our XFS top-of-tree.  I'll
hold off sending yet another pull request to Linus for
now.  Thanks for addressing it quickly.

					-Alex


> /me hates gcc's warning inconsistencies with a passion.
> 
>> e.g.:
>> 
>> In file included from linux-next-20091216/include/trace/ftrace.h:398,
>>                  from linux-next-20091216/include/trace/define_trace.h:69,
>>                  from linux-next-20091216/fs/xfs/linux-2.6/xfs_trace.h:1369,
>>                  from linux-next-20091216/fs/xfs/linux-2.6/xfs_trace.c:75:
>> linux-next-20091216/fs/xfs/linux-2.6/./xfs_trace.h: In function
>> 'ftrace_raw_output_id_xfs_iomap_enter': linux-next-20091216/fs/xfs/linux-2.6/./xfs_trace.h:830:
>> warning: format '%llx' expects type 'long long unsigned int', but argument 12 has type
>> 'xfs_fsblock_t'  
> 
> Patch that should fix this below.
> 
> Cheers,
> 
> Dave.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/