linux-kernel - [tip:x86/urgent] Makefile: Unexport LC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 17 Dec 2009 23:58:07 GMT
From:	"tip-bot for H. Peter Anvin" <hpa@...or.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, hpa@...or.com, mingo@...hat.com,
	sam@...nborg.org, rdreier@...co.com, tglx@...utronix.de,
	mmarek@...s.cz, mhiramat@...hat.com
Subject: [tip:x86/urgent] Makefile: Unexport LC_ALL instead of clearing it

Commit-ID:  06b5dc646b9479b786d77749936f25910cd82a37
Gitweb:     http://git.kernel.org/tip/06b5dc646b9479b786d77749936f25910cd82a37
Author:     H. Peter Anvin <hpa@...or.com>
AuthorDate: Thu, 17 Dec 2009 15:51:37 -0800
Committer:  H. Peter Anvin <hpa@...or.com>
CommitDate: Thu, 17 Dec 2009 15:51:37 -0800

Makefile: Unexport LC_ALL instead of clearing it

Apparently not all versions of glibc and utilities treat an empty
LC_ALL as nonexistent, causing error messages to be garbled.  Instead,
explicitly unexport it from the environment.

Reported-and-tested-by: Masami Hiramatsu <mhiramat@...hat.com>
Signed-off-by: H. Peter Anvin <hpa@...or.com>
LKML-Reference: <4B2AC394.4030108@...hat.com>
Cc: Michal Marek <mmarek@...s.cz>
Cc: Roland Dreier <rdreier@...co.com>
Cc: Sam Ravnborg <sam@...nborg.org>
---
 Makefile |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Makefile b/Makefile
index 6e39af1..5e92ca5 100644
--- a/Makefile
+++ b/Makefile
@@ -17,11 +17,11 @@ NAME = Man-Eating Seals of Antiquity
 MAKEFLAGS += -rR --no-print-directory
 
 # Avoid funny character set dependencies
-LC_ALL=
+unexport LC_ALL
 LC_CTYPE=C
 LC_COLLATE=C
 LC_NUMERIC=C
-export LC_ALL LC_CTYPE LC_COLLATE LC_NUMERIC
+export LC_CTYPE LC_COLLATE LC_NUMERIC
 
 # We are using a recursive build, so we need to do a little thinking
 # to get the ordering right.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/