linux-kernel - [PATCHv2 02/12]posix_acl: Add the check items

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 21 Dec 2009 19:52:58 +0800
From:	Liuwenyi <qingshenlwy@...il.com>
To:	chris.mason@...cle.com, viro@...iv.linux.org.uk,
	joel.becker@...cle.com, cjb@...top.org, jmorris@...ei.org,
	linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org,
	onlyflyer@...il.com, strongzgy@...il.com
Subject: [PATCHv2 02/12]posix_acl: Add the check items

move the ACL validation check in to fs/posix_acl.c.
Including nullpointer check and PTR_ERR check.


---
Signed-off-by: Liuwenyi <qingshenlwy@...il.com>
Cc: Chris Mason <chris.mason@...cle.com>
Cc: Al Viro <viro@...iv.linux.org.uk>
Cc: Joel Becker <joel.becker@...cle.com>
Cc: Chris Ball <cjb@...top.org>
Cc: James Morris <jmorris@...ei.org>
Cc: linux-btrfs@...r.kernel.org
Cc: linux-kernel@...r.kernel.org

---
diff --git a/fs/btrfs/acl.c b/fs/btrfs/acl.c
index 2e9e699..0f14f95 100644
--- a/fs/btrfs/acl.c
+++ b/fs/btrfs/acl.c
@@ -102,12 +102,9 @@ static int btrfs_set_acl(struct btrfs_trans_handle
*trans,
char *value = NULL;
mode_t mode;

- if (acl) {
- ret = posix_acl_valid(acl);
- if (ret < 0)
- return ret;
- ret = 0;
- }
+ ret = posix_acl_valid(acl);
+ if (ret < 0)
+ return ret;

switch (type) {
case ACL_TYPE_ACCESS:

-- 
Best Regards,
Liuwenyi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/