linux-kernel - Re: [PATCH] elf_fdpic_core_dump(): fix build break in 2.6.33-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 20 Dec 2009 21:14:12 -0500
From:	Masami Hiramatsu <mhiramat@...hat.com>
To:	Daisuke HATAYAMA <d.hatayama@...fujitsu.com>
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] elf_fdpic_core_dump(): fix build break in 2.6.33-rc1



Daisuke HATAYAMA wrote:
> The commit f6151dfea21496d43dbaba32cfcd9c9f404769bc causes build
> break, so this patch fixes it together with the correction for printk
> format.
> 
> Thanks.
> 
> Signed-off-by: Daisuke HATAYAMA <d.hatayama@...fujitsu.com>

Thanks for fixing that! looks good to me.

Reviewed-by: Masami Hiramatsu <mhiramat@...hat.com>

> ---
>  fs/binfmt_elf_fdpic.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/binfmt_elf_fdpic.c b/fs/binfmt_elf_fdpic.c
> index c25256a..b0f2732 100644
> --- a/fs/binfmt_elf_fdpic.c
> +++ b/fs/binfmt_elf_fdpic.c
> @@ -1798,11 +1798,11 @@ static int elf_fdpic_core_dump(struct coredump_params *cprm)
>  	ELF_CORE_WRITE_EXTRA_DATA;
>  #endif
>  
> -	if (file->f_pos != offset) {
> +	if (cprm->file->f_pos != offset) {
>  		/* Sanity check */
>  		printk(KERN_WARNING
> -		       "elf_core_dump: file->f_pos (%lld) != offset (%lld)\n",
> -		       file->f_pos, offset);
> +		       "elf_fdpic_core_dump: cprm->file->f_pos (%lld) != offset (%lld)\n",
> +		       cprm->file->f_pos, offset);
>  	}
>  
>  end_coredump:

-- 
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division

e-mail: mhiramat@...hat.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/