linux-kernel - Re: [Patch] thinkpad_acpi: fix a build error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 21 Dec 2009 19:00:20 -0800
From:	Marcel Holtmann <marcel@...tmann.org>
To:	"Helight.Xu" <helight.xu@...il.com>
Cc:	Henrique de Moraes Holschuh <hmh@....eng.br>,
	Takashi Iwai <tiwai@...e.de>, Xiaotian Feng <xtfeng@...il.com>,
	Amerigo Wang <amwang@...hat.com>, linux-kernel@...r.kernel.org,
	Corentin Chary <corentincj@...aif.net>,
	ibm-acpi-devel@...ts.sourceforge.net,
	Len Brown <len.brown@...el.com>,
	Alan Jenkins <alan-jenkins@...fmail.co.uk>,
	akpm@...ux-foundation.org
Subject: Re: [Patch] thinkpad_acpi: fix a build error

Hi Helight,

> >>> The patch isn't correct (I guess the upstream fix is same?).
> >>>
> >>> CONFIG_SOUND is a global config for sound subsystem.  The relevant
> >>> functions are ALSA core part, which is CONFIG_SND.
> >>> So, the fix should be:
> >>>
> >>> 	depends on SND
> >>>
> >>> instead.
> >>>       
> >> Indeed.  Ingo already fixed that too.
> >>
> >> Although I personally would prefer:
> >> select SOUND
> >> select SND
> >>
> >> But anything that stops the build errors will do for now.
> >>     
> >
> > I still haven't seen this patch in Linus' tree. And you do need select
> > SOUND and SND. Otherwise you still get build errors. I have tested this
> > on my machine. So can someone please submit a proper patch to get this
> > fixed.
> >   
> I think my first patch about this can fix it!
> 
> http://lkml.org/lkml/2009/12/18/141
> 
> I have tested it!

either depends on SND or select SND + SOUND, but one of them has to be
pushed into Linus' tree. Personally I don't care which one.

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/