linux-kernel - Re: linux-next: tty tree build failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 23 Dec 2009 16:19:22 -0800
From:	Greg KH <greg@...ah.com>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
Cc:	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Alan Cox <alan@...ux.intel.com>
Subject: Re: linux-next: tty tree build failure

On Thu, Dec 24, 2009 at 10:48:30AM +1100, Stephen Rothwell wrote:
> Hi Greg,
> 
> Today's linux-next build (x86_64 allmodconfig) failed like this:
> 
> drivers/mmc/card/sdio_uart.c: In function 'sdio_uart_add_port':
> drivers/mmc/card/sdio_uart.c:99: warning: passing argument 1 of 'kfifo_alloc' makes pointer from integer without a cast
> include/linux/kfifo.h:110: note: expected 'struct kfifo *' but argument is of type 'long unsigned int'
> drivers/mmc/card/sdio_uart.c:99: warning: passing argument 3 of 'kfifo_alloc' makes integer from pointer without a cast
> include/linux/kfifo.h:110: note: expected 'gfp_t' but argument is of type 'struct spinlock_t *'
> drivers/mmc/card/sdio_uart.c:99: warning: assignment makes pointer from integer without a cast
> drivers/mmc/card/sdio_uart.c: In function 'sdio_uart_transmit_chars':
> drivers/mmc/card/sdio_uart.c:476: error: implicit declaration of function 'kfifo_get'
> drivers/mmc/card/sdio_uart.c: In function 'sdio_uart_write':
> drivers/mmc/card/sdio_uart.c:810: error: implicit declaration of function 'kfifo_put'
> 
> Caused by commit ed30500af457c06b533549f5554671e58c4db18a ("tty:
> sdio_uart: Use kfifo instead of the messy circ stuff") interacting with
> the kfifo API change in Linus' tree.
> 
> I have reverted that commit for today.

Thanks, I'll delete that commit and let Alan resubmit it as the API has
now changed.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/