linux-kernel - Re: tree with htc dream support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 28 Dec 2009 13:08:27 -0800
From:	Brian Swetland <swetland@...gle.com>
To:	Pavel Machek <pavel@....cz>
Cc:	Arve Hjønnevåg <arve@...roid.com>,
	Daniel Walker <dwalker@...eaurora.org>,
	kernel list <linux-kernel@...r.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	Iliyan Malchev <malchev@...gle.com>, Greg KH <greg@...ah.com>
Subject: Re: tree with htc dream support

On Mon, Dec 28, 2009 at 12:48 PM, Pavel Machek <pavel@....cz> wrote:
>> > In the short run... the code is staging quality, so it should be in
>> > staging... and you'll not have to mainain so huge diff. (-20 kLoc).
>>
>> The core smd stuff is really not that large.  The central smd.[ch] are
>> about 1300 lines, and proc_comm.[ch] are about 400 lines.  Is it
>> possible to get some review/feedback as to what's "staging quality"
>> about this code so we can clean it up?  I'd rather just fix the
>> issues
>
> Just submit it to Daniel W., ccing rmk and l-a-k, and I'm sure you'll
> get feedback.
>
> For a start, checkpatch has some mild complains.
>
>> and get the core stuff in there so clock, power, etc support is there
>> for the platform rather than have it live in staging purgatory.
>>
>> Since this stuff is integral to mach-msm, required for essential
>> operation of the platform, and makes sense to be part of the mach-msm
>> codebase, why not just fix it there rather than move it out into
>> staging and then back?  I'm not sure what that gains us.
>
> Well, it is in staging now. I just want you to use the existing
> version, instead of adding another one.

I'm trying to understand where the version in staging came from, how
it's been changed, etc, so I can resolve that against what we have
that's known good and shipping today and make sure we're not losing
bugfixes and such along the way.

Do you remember where the smd code that you put into staging came
from, exactly?  Unfortunately since things have been moved, modified,
renamed, etc, getting clean diffs is a bit of an adventure right now.

When I'm back in the office (on vacation at the moment, trying to stay
caught up on email though) I'll have to start figuring out what went
where and how different it is from what we have today, say in Arve's
.33 based tree.

Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/