linux-kernel - Re: [PATCH v4 4/4] memcg: implement memory thresholds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 30 Dec 2009 15:03:25 +0200
From:	"Kirill A. Shutemov" <kirill@...temov.name>
To:	Daisuke Nishimura <nishimura@....nes.nec.co.jp>
Cc:	containers@...ts.linux-foundation.org, linux-mm@...ck.org,
	Paul Menage <menage@...gle.com>,
	Li Zefan <lizf@...fujitsu.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	Balbir Singh <balbir@...ux.vnet.ibm.com>,
	Pavel Emelyanov <xemul@...nvz.org>,
	Dan Malek <dan@...eddedalley.com>,
	Vladislav Buzov <vbuzov@...eddedalley.com>,
	Alexander Shishkin <virtuoso@...nd.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 4/4] memcg: implement memory thresholds

On Mon, Dec 28, 2009 at 6:42 AM, Daisuke Nishimura
<nishimura@....nes.nec.co.jp> wrote:
> It would be a nitpick, but my patch(http://marc.info/?l=linux-mm-commits&m=126152804420992&w=2)
> has already modified here.
>
> I think it might be better for you to apply my patches by hand or wait for next mmotm
> to be released to avoid bothering Andrew.
> (There is enough time left till the next merge window :))

I'll rebase it later.

> (snip)
>
>> +static void __mem_cgroup_threshold(struct mem_cgroup *memcg, bool swap)
>> +{
>> +     struct mem_cgroup_threshold_ary *thresholds;
>> +     u64 usage = mem_cgroup_usage(memcg, swap);
>> +     int i, cur;
>> +
> I think calling mem_cgroup_usage() after checking "if(!thresholds)"
> decreases the overhead a little when we don't set any thresholds.
> I've confirmed that the change makes the assembler output different.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/