linux-kernel - Re: [PATCH] input, mouse: Change the prototype of functions in lifebook.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 30 Dec 2009 19:29:01 +0600
From:	Rakib Mullick <rakib.mullick@...il.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Alessandro Rubini <rubini@...vis.unipv.it>
Subject: Re: [PATCH] input, mouse: Change the prototype of functions in 
	lifebook.c

On 12/30/09, Dmitry Torokhov <dmitry.torokhov@...il.com> wrote:
>
> I suppose it is CONFIG_DMI, not CONFIG_PM... In fact, we should simply
>  make this driver depend on CONFIG_DMI.

Oh.. yes. I made a stupid mistake. Please checkout the following patch.

-------

 input, mouse: Make lifebook mouse driver depend on CONFIG_DMI.

When CONFIG_DMI=n, then we are warned by the following warning:

drivers/input/mouse/lifebook.c:33: warning: 'lifebook_limit_serio3'
defined but not used
drivers/input/mouse/lifebook.c:41: warning: 'lifebook_set_6byte_proto'
defined but not used

We need to make this driver depend on CONFIG_DMI.



Signed-off-by: Rakib Mullick <rakib.mullick@...il.com>
---

--- linus/drivers/input/mouse/Kconfig	2009-12-28 12:37:51.000000000 +0600
+++ rakib/drivers/input/mouse/Kconfig	2009-12-30 20:24:31.000000000 +0600
@@ -70,7 +70,7 @@ config MOUSE_PS2_SYNAPTICS
 config MOUSE_PS2_LIFEBOOK
 	bool "Fujitsu Lifebook PS/2 mouse protocol extension" if EMBEDDED
 	default y
-	depends on MOUSE_PS2 && X86
+	depends on MOUSE_PS2 && X86 && DMI
 	help
 	  Say Y here if you have a Fujitsu B-series Lifebook PS/2
 	  TouchScreen connected to your system.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/