linux-kernel - Re: users of mod_timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 2 Jan 2010 11:19:46 -0800
From:	Arjan van de Ven <arjan@...radead.org>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	tglx@...utronix.de, linux-kernel@...r.kernel.org
Subject: Re: users of mod_timer_msec()

On Sat, 02 Jan 2010 20:11:45 +0100
Andi Kleen <andi@...stfloor.org> wrote:

> Arjan van de Ven <arjan@...radead.org> writes:
> 
> >  	emp->activity++;
> >  	if (!timer_pending(&emp->timer))
> > -		mod_timer(&emp->timer, jiffies +
> > msecs_to_jiffies(10));
> > +		mod_timer_msec(&emp->timer, 10);
> 
> ... but your original patch does
> 
> +int mod_timer_msec(struct timer_list *timer, unsigned long delay_ms)
> +{
> +       return mod_timer(timer, msecs_to_jiffies(delay_ms));
> 

eh last minute typo

this is supposed to be jiffies + msecs_to_jiffies()

good catch; thanks!


-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/