linux-kernel - Re: [PATCH] Logitech G13 driver (fixed cc list --- ignore others)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 5 Jan 2010 10:52:08 +0100 (CET)
From:	Jiri Kosina <jkosina@...e.cz>
To:	"Rick L. Vinyard, Jr." <rvinyard@...nmsu.edu>
Cc:	Pavel Machek <pavel@....cz>, linux-kernel@...r.kernel.org,
	krzysztof.h1@...pl, Andrew Morton <akpm@...ux-foundation.org>,
	linux-usb@...r.kernel.org, Oliver Neukum <oliver@...kum.org>,
	linux-input@...r.kernel.org
Subject: Re: [PATCH] Logitech G13 driver (fixed cc list --- ignore others)

On Mon, 4 Jan 2010, Rick L. Vinyard, Jr. wrote:

> >> > This patch is against the torvalds/linux-2.6.git tree.
> >>
> >> Should this use auxdisplay framework and be located there?
> >
> > Well, the device is still primarily HID device in its nature, so either
> > keeping the whole driver in drivers/hid, or separating it into two
> > drivers, one for the HID part and second for the framebuffer part should
> > be acceptable.
> 
> The framebuffer part uses the same interrupt endpoint for both HID and
> display. IIRC there were issues with two drivers using the same interrupt
> endpoint.

I have no objection to keeping this as a single driver in drivers/hid, 
provided that the framebuffer part gets reviewed by someone more familiar 
with the framebuffer code than I am.

> > I will proceed with reviewing the driver soon, sorry for slightly higher
> > latencies these days.
> 
> No problem... as you can see my latency responding is rather high.

Also please see the other thread about the build failures I am getting 
with this drivers (and it's not fixed solely by making the driver 
dependent on FB_DEFERRED_IO (namely it doesn't like to be built in as 
module, because of the symbol name clashes with hid-lg).

Thanks,

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/