linux-kernel - Re: [PATCH v2] scripts: add ARM support to decodecode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 05 Jan 2010 16:34:23 +0100
From:	Michal Marek <mmarek@...e.cz>
To:	Arjan van de Ven <arjan@...ux.intel.com>
Cc:	Rabin Vincent <rabin@....in>, Simon Horman <horms@...ge.net.au>,
	wangcong@...ux.org, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2] scripts: add ARM support to decodecode

On 5.1.2010 16:06, Arjan van de Ven wrote:
> On Tue, 5 Jan 2010 20:27:58 +0530
> Rabin Vincent <rabin@....in> wrote:
> 
>> This patch adds support for decoding ARM oopses to scripts/decodecode.
>> The following things are handled:
>>
>>  - ARCH and CROSS_COMPILE environment variables are respected.
>>
>>  - The Code: in x86 oopses is in bytes, while it is in either words (4
>>    bytes) or halfwords for ARM.
>>
>>  - Some versions of ARM objdump refuse to disassemble instructions
>>    generated by literal constants (".word 0x...").  The workaround is
>> to strip the object file first.
>>
>>  - The faulting instruction is marked (liked so) in ARM, but <like so>
>>    in x86.
>>
>>  - ARM mnemonics may include characters such as [] which need to be
>>    escaped before being passed to sed for the "<- trapping
>> instruction" substitution.
> 
> 
> I'm fine with this,

Was this an Acked-by? :)


> but I wonder if ARM could switch to the <>
> convention for the faulting instruction, just to keep things
> consistent..

I added the patch to the kbuild tree. () won't appear in the x86 Code:
line, so there should be no problem.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/