| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 5 Jan 2010 17:21:06 +0100 From: Andi Kleen <andi@...stfloor.org> To: Greg KH <greg@...ah.com> Cc: Andi Kleen <andi@...stfloor.org>, linux-kernel@...r.kernel.org Subject: Re: [PATCH] [4/12] SYSFS: Add sysfs_add/remove_files utility functions On Tue, Jan 05, 2010 at 06:53:09AM -0800, Greg KH wrote: > On Tue, Jan 05, 2010 at 12:48:01PM +0100, Andi Kleen wrote: > > > > Adding/Removing a whole array of attributes is very common. Add a standard > > utility function to do this with a simple function call, instead of > > requiring drivers to open code this. > > Hm, that is what the sysfs_create_group(), sysfs_update_group(), and > sysfs_remove_group() functions are for. We don't need to add any new > functions that do the same thing, right? Hmm, originally I didn't use them because they created a sub-directory, but I see now that's optional. Still the input format is completely different and doesn't fit into the ->attrs list that are used elsewhere (e.g. for the sysdev_classes) So using groups would need a lot of restructuring. Also similar code as I have is already in a lot of places, which over time will be converted. So it's definitely less code than before. -Andi -- ak@...ux.intel.com -- Speaking for myself only. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists