linux-kernel - Re: mfd: twl4030-irq: irq_desc->lock converted to raw_spinlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 5 Jan 2010 20:34:19 +0100
From:	Samuel Ortiz <sameo@...ux.intel.com>
To:	Tony Lindgren <tony@...mide.com>
Cc:	Felipe Balbi <felipe.balbi@...ia.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-omap@...r.kernel.org
Subject: Re: mfd: twl4030-irq: irq_desc->lock converted to raw_spinlock_t

Hi Tony,

On Mon, Dec 28, 2009 at 12:01:45PM -0800, Tony Lindgren wrote:
> * Felipe Balbi <felipe.balbi@...ia.com> [091228 03:04]:
> > commit 239007b8440abff689632f50cdf0f2b9e895b534 converted
> > the spinlock_t to raw_spinlock_t. Unfortunately twl4030-irq
> > was left aside on the conversion.
> > 
> > Cc: Tony Lindgren <tony@...mide.com>
> > Cc: linux-omap@...r.kernel.org
> > Acked-by: Thomas Gleixner <tglx@...utronix.de>
> > Signed-off-by: Felipe Balbi <felipe.balbi@...ia.com>
> > 
> > ---
> > 
> > resending because it wasn't applied before
> 
> This should go via Samuel as it's MFD related.
Linus applied it to his tree directly.

Cheers,
Samuel.


> Acked-by: Tony Lindgren <tony@...mide.com>
> 
>  
> > 
> >  drivers/mfd/twl4030-irq.c |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c
> > index 20d29ba..9df9a5a 100644
> > --- a/drivers/mfd/twl4030-irq.c
> > +++ b/drivers/mfd/twl4030-irq.c
> > @@ -568,12 +568,12 @@ static void twl4030_sih_do_edge(struct work_struct *work)
> >  
> >  		bytes[byte] &= ~(0x03 << off);
> >  
> > -		spin_lock_irq(&d->lock);
> > +		raw_spin_lock_irq(&d->lock);
> >  		if (d->status & IRQ_TYPE_EDGE_RISING)
> >  			bytes[byte] |= BIT(off + 1);
> >  		if (d->status & IRQ_TYPE_EDGE_FALLING)
> >  			bytes[byte] |= BIT(off + 0);
> > -		spin_unlock_irq(&d->lock);
> > +		raw_spin_unlock_irq(&d->lock);
> >  
> >  		edge_change &= ~BIT(i);
> >  	}

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/