linux-kernel - Re: [GIT PULL] Please pull NFS client bugfixes....

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 7 Jan 2010 22:35:04 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Peter Staubach <staubach@...hat.com>
Cc:	Andi Kleen <andi@...stfloor.org>, Trond.Myklebust@...app.com,
	linux-kernel@...r.kernel.org, torvalds@...l.org
Subject: Re: [GIT PULL] Please pull NFS client bugfixes....

On Thu, Jan 07, 2010 at 04:23:22PM -0500, Peter Staubach wrote:
> It seems to me that NFS must do some sort of validation at
> this point.  This is one of the last points where the NFS
> client can do validation for mmap'd files.

Typically there is a open directly before it. open seems
like a much more natural point to synchronize than mmap.

Also so far nobody could point me to a standard text or similar
who said mmap needs synchronization, just some vague beliefs.

And the fact is right now with the current Linux VFS and
NFS locking mmap can't do it reliably.

> I think that the file system must have a way to do validation
> and page invalidation during mmap.  Perhaps we can reorder
> things or add another entry point which is invoked after the
> page mapping is set up which would give the file system to
> check to ensure that the page cache is filled with valid data.

If someone has a better patch feel free to post it, but ignoring
the problem like it has been done so far doesn't fly.

I know that my patch works for me at least.

-Andi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/