linux-kernel - [patch] generic-ipi: fix backtrace in smp_call_function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 07 Jan 2010 15:46:59 -0800
From:	Suresh Siddha <suresh.b.siddha@...el.com>
To:	Rusty Russell <rusty@...tcorp.com.au>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...e.hu>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: [patch] generic-ipi: fix backtrace in smp_call_function_any()

On my westmere box, I see this backtrace with 2.6.33-rc kernels:

> cpumask_of_node(3): node > nr_node_ids(1)
> Pid: 1, comm: swapper Not tainted 2.6.33-rc3-00097-g2c1f189 #223
> Call Trace:
>  [<ffffffff81028bb3>] cpumask_of_node+0x23/0x58
>  [<ffffffff81061f51>] smp_call_function_any+0x65/0xfa
>  [<ffffffff810160d1>] ? do_drv_read+0x0/0x2f
>  [<ffffffff81015fba>] get_cur_val+0xb0/0x102
>  [<ffffffff81016080>] get_cur_freq_on_cpu+0x74/0xc5
>  [<ffffffff810168a7>] acpi_cpufreq_cpu_init+0x417/0x515
>  [<ffffffff81562ce9>] ? __down_write+0xb/0xd
>  [<ffffffff8148055e>] cpufreq_add_dev+0x278/0x922

fix it by using the cpu_to_node() and using the node number instead
of the cpu for cpumask_of_node().

Signed-off-by: Suresh Siddha <suresh.b.siddha@...el.com>
---

diff --git a/kernel/smp.c b/kernel/smp.c
index de735a6..f104084 100644
--- a/kernel/smp.c
+++ b/kernel/smp.c
@@ -347,7 +347,7 @@ int smp_call_function_any(const struct cpumask *mask,
 		goto call;
 
 	/* Try for same node. */
-	nodemask = cpumask_of_node(cpu);
+	nodemask = cpumask_of_node(cpu_to_node(cpu));
 	for (cpu = cpumask_first_and(nodemask, mask); cpu < nr_cpu_ids;
 	     cpu = cpumask_next_and(cpu, nodemask, mask)) {
 		if (cpu_online(cpu))


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/