linux-kernel - Re: mmotm 2010-01-06-14-34 uploaded (kernel/cgroup)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 7 Jan 2010 11:47:28 +0900
From:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
To:	Li Zefan <lizf@...fujitsu.com>
Cc:	Randy Dunlap <randy.dunlap@...cle.com>, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org,
	"menage@...gle.com" <menage@...gle.com>, kirill@...temov.name
Subject: Re: mmotm 2010-01-06-14-34 uploaded (kernel/cgroup)

On Thu, 07 Jan 2010 10:41:15 +0800
Li Zefan <lizf@...fujitsu.com> wrote:

> KAMEZAWA Hiroyuki wrote:
> > On Wed, 6 Jan 2010 17:08:49 -0800
> > Randy Dunlap <randy.dunlap@...cle.com> wrote:
> > 
> >> On Wed, 06 Jan 2010 14:34:36 -0800 akpm@...ux-foundation.org wrote:
> >>
> >>> The mm-of-the-moment snapshot 2010-01-06-14-34 has been uploaded to
> >>>
> >>>    http://userweb.kernel.org/~akpm/mmotm/
> >>>
> >>> and will soon be available at
> >>>
> >>>    git://zen-kernel.org/kernel/mmotm.git
> >>>
> >>> It contains the following patches against 2.6.33-rc3:
> >>
> >> kernel/cgroup.c: In function 'cgroup_write_event_control':
> >> kernel/cgroup.c:2949: error: implicit declaration of function 'eventfd_fget'
> >> kernel/cgroup.c:2949: warning: assignment makes pointer from integer without a cast
> >> kernel/cgroup.c:2955: error: implicit declaration of function 'eventfd_ctx_fileget'
> >> kernel/cgroup.c:2955: warning: assignment makes pointer from integer without a cast
> >> make[2]: *** [kernel/cgroup.o] Error 1
> >>
> > 
> > Hmm, how about this rather than adding #ifdefs..
> > Paul, Li, how do you think ?
> 
> I think make CONFIG_CGROUPS select EVENTFD would be better.
> 
Hm, as far as I know, SELECT is not recommended. But yes, it seems side-effect
of select is small here. But I avoid it as much as possible, usually.

Moreover, in this case,
  - EVENTFD is a feature which is enabled by default.
  - cgroup is "Say N if unsure" config.

In this case, "depends on" is good.

Thanks,
-Kame

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/