lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4B47B031.5000406@zytor.com>
Date:	Fri, 08 Jan 2010 14:22:41 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Christoph Hellwig <hch@....de>
CC:	Al Viro <viro@...IV.linux.org.uk>, Matthew Wilcox <matthew@....cx>,
	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	linux-arch@...r.kernel.org, linux@....linux.org.uk,
	dhowells@...hat.com, ysato@...rs.sourceforge.jp,
	tony.luck@...el.com, geert@...ux-m68k.org, zippel@...ux-m68k.org,
	gerg@...inux.org, schwidefsky@...ibm.com,
	heiko.carstens@...ibm.com, jdike@...toit.com, tglx@...utronix.de,
	mingo@...hat.com
Subject: Re: [PATCH 1/3] generic sys_old_select

On 01/08/2010 01:31 AM, Christoph Hellwig wrote:
> On Wed, Jan 06, 2010 at 05:41:09PM +0000, Al Viro wrote:
>> Actually, I'd be a lot happier if we had lib/syscall/old_select.c, instead
>> of cluttering fs/select.c with that.  Objections?
> 
> If we do that let's do it consistantly for various old syscalls, not
> an odd one out.

Yes, and it would be a good idea to do so, rather than hiding all these
compatibility calls in all kind of random places.

There is, however, a reason *not* to do it which should be carefully
considered: by co-locating the compatibility version with the modern
version, it gets access to static functions that are part of the
implementation of the modern version.  If we move the compatibility
versions out, it may entail having to export those statics.

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ