lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 8 Jan 2010 16:43:51 -0800 From: "H. Peter Anvin" <hpa@...or.com> To: "Masami Hiramatsu" <mhiramat@...hat.com> Cc: "H. Peter Anvin" <hpa@...or.com>, "Michal Marek" <mmarek@...e.cz>, "Simon Horman" <horms@...ge.net.au>, "Roland Dreier" <rdreier@...co.com>, "Sam Ravnborg" <sam@...nborg.org>, "Sergei Trofimovich" <slyfox@...ox.ru>, linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org, linux-sh@...r.kernel.org Subject: Re: [PATCH] Makefile: do not override LC_CTYPE > H. Peter Anvin wrote: >> On 01/08/2010 04:09 PM, Masami Hiramatsu wrote: >>> Hi Michal, >>> >>> Michal Marek wrote: >>>> Setting LC_CTYPE=C breaks localized messages in some setups. With only >>>> LC_COLLATE=C and LC_NUMERIC=C, we get almost all we need, except for >>>> not >>>> so defined character classes and tolower()/toupper(). The former is >>>> not >>>> a big issue, because we can assume that e.g. [:alpha:] will always >>>> include a-zA-Z and we only ever process ASCII input. The latter seems >>>> only affect arch/sh/tools/gen-mach-types, which we can handle >>>> separately. >>> >>> Hmm, this also affects arch/x/tools/gen-insn-attr-x86.awk. >>> Could you also wrap it? >>> >> >> This is tolower/toupper()? Do there exist locales where tolower/toupper >> on ASCII input do weird things, or are we merely hypothesizing? > > Isn't it affect [A-Z] or [a-z]? If not, the patch good to me too. > [A-Z][a-z] is what LC_COLLATE is about. -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists