lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 10 Jan 2010 12:23:01 +0100 From: Jiri Slaby <jirislaby@...il.com> To: unlisted-recipients:; (no To-header on input) CC: gregkh@...e.de, akpm@...ux-foundation.org, linux-kernel@...r.kernel.org, Alan Cox <alan@...ux.intel.com> Subject: Re: [PATCH 1/1] Char: synclink, fix potential null dereference On 01/10/2010 09:51 AM, Jiri Slaby wrote: > Stanse found a potential null dereference in mgsl_put_char and > mgsl_write. There is a check for tty being NULL, but it is > dereferenced earlier. Move the dereference after the check. > > Also reorder mgsl_paranoia_check so that it makes sense: > * check !tty > * deref tty > * check !info > * deref info Actually, this is wrong, .write and .put_char cannot be called with NULL tty. -- js -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists