linux-kernel - Re: [PATCH] vgaarb: fix typo deference when copying from userspace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 12 Jan 2010 19:56:37 +0100
From:	Helge Deller <deller@....de>
To:	Tiago Vignatti <tiago.vignatti@...ia.com>
CC:	Dave Airlie <airlied@...hat.com>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	"Paulo R. Zanoni" <przanoni@...il.com>,
	Henry Zhao <Henry.Zhao@....COM>,
	Andy Getzendanner <james.getzendanner@...dents.olin.edu>,
	Brad Spengler <spender@...ecurity.net>,
	"dri-devel@...ts.sf.net" <dri-devel@...ts.sf.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-parisc <linux-parisc@...r.kernel.org>
Subject: Re: [PATCH] vgaarb: fix typo deference when copying from userspace

On 01/12/2010 06:58 PM, Tiago Vignatti wrote:
> From: Brad Spengler<spender@...ecurity.net>
>
> libpciaccess is not triggering such code though.
>
> Signed-off-by: Tiago Vignatti<tiago.vignatti@...ia.com>

I can confirm, that this patch is needed to prevent a kernel
segfault with 2.6.33-rc3  on the parisc/hppa architecture.

Tested-by: Helge Deller <deller@....de>

> ---
> Andy Getzendanner tried to fix this, but he seems did a wrong approach:
> http://marc.info/?l=linux-kernel&m=126112173704466
>
> Andy: please test (and put your tag review!) this one instead. Thanks.
>
>   drivers/gpu/vga/vgaarb.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpu/vga/vgaarb.c b/drivers/gpu/vga/vgaarb.c
> index 1ac0c93..2f6cf69 100644
> --- a/drivers/gpu/vga/vgaarb.c
> +++ b/drivers/gpu/vga/vgaarb.c
> @@ -961,7 +961,7 @@ static ssize_t vga_arb_write(struct file *file, const char __user * buf,
>   		remaining -= 7;
>   		pr_devel("client 0x%p called 'target'\n", priv);
>   		/* if target is default */
> -		if (!strncmp(buf, "default", 7))
> +		if (!strncmp(curr_pos, "default", 7))
>   			pdev = pci_dev_get(vga_default_device());
>   		else {
>   			if (!vga_pci_str_to_vars(curr_pos, remaining,

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/