Date:	Wed, 13 Jan 2010 10:11:35 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Arnaldo Carvalho de Melo <acme@...radead.org>
Cc:	linux-kernel@...r.kernel.org,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Fr??d??ric Weisbecker <fweisbec@...il.com>,
	Mike Galbraith <efault@....de>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>
Subject: Re: [PATCH 5/6] perf tools: Use rb_for_each_entry


* Arnaldo Carvalho de Melo <acme@...radead.org> wrote:

> From: Arnaldo Carvalho de Melo <acme@...hat.com>
> 
> Cc: Fr??d??ric Weisbecker <fweisbec@...il.com>
> Cc: Mike Galbraith <efault@....de>
> Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> Cc: Paul Mackerras <paulus@...ba.org>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
> ---
>  tools/perf/builtin-annotate.c |   19 ++++++-------------
>  tools/perf/builtin-diff.c     |    5 ++---
>  tools/perf/builtin-kmem.c     |   12 +++++-------
>  tools/perf/builtin-sched.c    |   10 ++--------
>  tools/perf/builtin-top.c      |   10 +++-------
>  tools/perf/util/symbol.c      |   16 ++++++----------
>  6 files changed, 24 insertions(+), 48 deletions(-)

hm, this one doesnt build very well:

touch .perf.dev.null
    CC builtin-annotate.o
    CC builtin-diff.o
    CC builtin-sched.o
    CC builtin-top.o
    CC builtin-kmem.o
    CC util/symbol.o
cc1: warnings being treated as errors
builtin-diff.c: In function 'perf_session__match_hists':
builtin-diff.c:148: error: implicit declaration of function 'rb_for_each_entry'
builtin-diff.c:148: error: nested extern declaration of 'rb_for_each_entry'
builtin-diff.c:148: error: 'rb_node' undeclared (first use in this function)
builtin-diff.c:148: error: (Each undeclared identifier is reported only once
builtin-diff.c:148: error: for each function it appears in.)
builtin-diff.c:149: error: expected ';' before 'pos'
builtin-diff.c:142: error: unused parameter 'old_session'
make: *** [builtin-diff.o] Error 1
make: *** Waiting for unfinished jobs....
cc1: warnings being treated as errors
builtin-annotate.c: In function 'print_summary':
builtin-annotate.c:352: error: implicit declaration of function 'rb_for_each_entry'
builtin-annotate.c:352: error: nested extern declaration of 'rb_for_each_entry'
builtin-annotate.c:352: error: expected ';' before '{' token
builtin-annotate.c: In function 'perf_session__find_annotations':
builtin-annotate.c:426: error: 'rb_node' undeclared (first use in this function)
builtin-annotate.c:426: error: (Each undeclared identifier is reported only once
builtin-annotate.c:426: error: for each function it appears in.)
builtin-annotate.c:426: error: expected ';' before '{' token
make: *** [builtin-annotate.o] Error 1
cc1: warnings being treated as errors
builtin-top.c: In function 'print_sym_table':
builtin-top.c:535: error: implicit declaration of function 'rb_for_each_entry'
builtin-top.c:535: error: nested extern declaration of 'rb_for_each_entry'
builtin-top.c:535: error: 'rb_node' undeclared (first use in this function)
builtin-top.c:535: error: (Each undeclared identifier is reported only once
builtin-top.c:535: error: for each function it appears in.)
builtin-top.c:535: error: expected ';' before '{' token
builtin-top.c:569: error: expected ';' before '{' token
builtin-top.c:446: error: unused variable 'printed'
cc1: warnings being treated as errors
builtin-kmem.c: In function '__print_result':
builtin-kmem.c:364: error: implicit declaration of function 'rb_for_each_entry'
builtin-kmem.c:364: error: nested extern declaration of 'rb_for_each_entry'
builtin-kmem.c:364: error: 'node' undeclared (first use in this function)
builtin-kmem.c:364: error: (Each undeclared identifier is reported only once
builtin-kmem.c:364: error: for each function it appears in.)
builtin-kmem.c:364: error: expected ';' before '{' token
builtin-kmem.c:353: error: unused parameter 'session'
builtin-kmem.c:354: error: unused parameter 'n_lines'
make: *** [builtin-kmem.o] Error 1
make: *** [builtin-top.o] Error 1
cc1: warnings being treated as errors
builtin-sched.c: In function '__cmd_lat':
builtin-sched.c:1719: error: implicit declaration of function 'rb_for_each_entry'
builtin-sched.c:1719: error: nested extern declaration of 'rb_for_each_entry'
builtin-sched.c:1719: error: 'node' undeclared (first use in this function)
builtin-sched.c:1719: error: (Each undeclared identifier is reported only once
builtin-sched.c:1719: error: for each function it appears in.)
builtin-sched.c:1720: error: expected ';' before 'output_lat_thread'
make: *** [builtin-sched.o] Error 1
cc1: warnings being treated as errors
util/symbol.c: In function 'symbols__sort_by_name':
util/symbol.c:297: error: implicit declaration of function 'rb_for_each_entry'
util/symbol.c:297: error: nested extern declaration of 'rb_for_each_entry'
util/symbol.c:297: error: 'rb_node' undeclared (first use in this function)
util/symbol.c:297: error: (Each undeclared identifier is reported only once
util/symbol.c:297: error: for each function it appears in.)
util/symbol.c:298: error: expected ';' before 'symbols__insert_by_name'
util/symbol.c:292: error: unused parameter 'self'
util/symbol.c: In function 'dso__fprintf':
util/symbol.c:378: error: 'rb_node' undeclared (first use in this function)
util/symbol.c:379: error: expected ';' before 'ret'
util/symbol.c: In function 'map_groups__find_by_name':
util/symbol.c:1342: error: 'rb_node' undeclared (first use in this function)
util/symbol.c:1343: error: expected ';' before 'if'
util/symbol.c:1337: error: unused parameter 'name'
make: *** [util/symbol.o] Error 1
rm .perf.dev.null

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists