linux-kernel - Re: [RESEND PATCH 5/5] spi/mpc8xxx: don't check platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 13 Jan 2010 14:17:03 +0300
From:	Anton Vorontsov <avorontsov@...mvista.com>
To:	Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Cc:	linux-kernel@...r.kernel.org, David Vrabel <dvrabel@...om.com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	David Brownell <dbrownell@...rs.sourceforge.net>,
	Grant Likely <grant.likely@...retlab.ca>,
	Kumar Gala <galak@...nel.crashing.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	spi-devel-general@...ts.sourceforge.net
Subject: Re: [RESEND PATCH 5/5] spi/mpc8xxx: don't check platform_get_irq's
 return value against zero

On Wed, Jan 13, 2010 at 12:05:46PM +0100, Uwe Kleine-König wrote:
> platform_get_irq returns -ENXIO on failure, so !irq was probably
> always true.  Make irq a signed variable and compare irq <= 0.  Note
> that a return value of zero is still handled as error even though this
> could mean irq0.
> 
> This is a followup to 305b3228f9ff4d59f49e6d34a7034d44ee8ce2f0 that
> changed the return value of platform_get_irq from 0 to -ENXIO on error.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> Cc: David Vrabel <dvrabel@...om.com>
> Cc: Greg Kroah-Hartman <gregkh@...e.de>
> Cc: David Brownell <dbrownell@...rs.sourceforge.net>
> Cc: Grant Likely <grant.likely@...retlab.ca>
> Cc: Kumar Gala <galak@...nel.crashing.org>
> Cc: Anton Vorontsov <avorontsov@...mvista.com>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: spi-devel-general@...ts.sourceforge.net
> ---

Acked-by: Anton Vorontsov <avorontsov@...mvista.com>

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/