| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 13 Jan 2010 15:43:54 +0400 From: Manu Abraham <abraham.manu@...il.com> To: Jiri Slaby <jirislaby@...il.com> Cc: Andy Walls <awalls@...ix.net>, mchehab@...hat.com, hverkuil@...all.nl, ivtv-devel@...vdriver.org, linux-media@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/1] media: video/cx18, fix potential null dereference On Tue, Jan 12, 2010 at 3:28 PM, Jiri Slaby <jirislaby@...il.com> wrote: > On 01/12/2010 12:48 AM, Andy Walls wrote: >> On Sun, 2010-01-10 at 09:56 +0100, Jiri Slaby wrote: >>> Stanse found a potential null dereference in cx18_dvb_start_feed >>> and cx18_dvb_stop_feed. There is a check for stream being NULL, >>> but it is dereferenced earlier. Move the dereference after the >>> check. >>> >>> Signed-off-by: Jiri Slaby <jslaby@...e.cz> >> >> Reviewed-by: Andy Walls <awalls@...ix.net> >> Acked-by: Andy Walls <awalls@...ix.net> > > You definitely know the code better, have you checked that it can happen > at all? I mean may demux->priv be NULL? It is highly unlikely that demux->priv becoming NULL. The only time that could happen would be when there is a dvb register failed. But in which case, it wouldn't reach the stage where you want to start/stop a stream. Regards, Manu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists