linux-kernel - RE: [PATCH 1/1] atmel uaba : Adding invert vbus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 13 Jan 2010 14:20:40 +0100
From:	Eirik Aanonsen <EAA@...medical.com>
To:	Eirik Aanonsen <EAA@...medical.com>,
	"kernel@...32linux.org" <kernel@...32linux.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 1/1] atmel uaba : Adding invert vbus_pin

> Subject: [PATCH 1/1] atmel uaba : Adding invert vbus_pin
> 
> Thanks to Ben Nizette [bn@...sdigital.com] and Sergei Shtylyov
> [sshtylyov@...mvista.com] for good feedback
> 
> Adding vbus_pin_inverted so that the usb detect pin can be active high
> or low.
> This because depending on HW implementation it is better to have active
> low.
> Also replaced the pio_get_value(udc->vbus_pin); with a call to
> vbus_is_present(udc);
> 
> Signed-off-by: Eirik Aanonsen <eaa@...medical.com>
> ---

...

No one that have any comments on this? 

Haavard is it possible to get this upstream?

The patch allows the USB driver to be active and when the USB bus is disconnected (with reversed signaling).
I observe a drop in power consumption of 150mW, and for people dependent on battery that is a lot.
And in our design we need to have this pin inverted.

Regards
____________________________________________________
 
Eirik Aanonsen
SW Developer
E-mail: eaa@...medical.com 
Phone: +47 90 68 11 92
Fax: +47 37 03 56 77
____________________________________________________


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/