linux-kernel - Re: [PATCH] drm/i915: disable LVDS downclock by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 14 Jan 2010 13:51:38 -0800
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	Pekka Enberg <penberg@...helsinki.fi>
Cc:	Nick Bowler <nbowler@...iptictech.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	airlied@...ux.ie, eric@...olt.net, intel-gfx@...ts.freedesktop.org
Subject: Re: [PATCH] drm/i915: disable LVDS downclock by default

On Thu, 14 Jan 2010 23:25:57 +0200
Pekka Enberg <penberg@...helsinki.fi> wrote:

> Hi Jesse,
> 
> On Thu, Jan 14, 2010 at 10:48 PM, Jesse Barnes
> <jbarnes@...tuousgeek.org> wrote:
> > Many platform support this feature, and it can provide significant
> > power savings when the reduced refresh rate is low.  However, on
> > some platforms a secondary (reduced) timing is provided but not
> > actually supported by the hardware.  This results in undesirable
> > flicker at runtime.
> >
> > So disable the feature by default, but allow users to opt-in to the
> > reduced clock behavior with a new module parameter, lvds_downclock,
> > that can be set to 1 to enable the feature.
> >
> > Signed-off-by: Jesse Barnes <jbarnes@...tuousgeek.org>
> >
> > --
> >
> > Nick and Pekka, please try this out and reply with your Tested-by
> > (assuming it works, if not I'll fix it up).
> 
> This gives me pretty much identical results as your original patch.
> That is, the "shakes" are gone but I still see the occasional "flash".
> Should I give Nick's patch a try to see if we're looking at the same
> issue or wait for your new patch?

Nick's patch should be the same, thanks for testing.

-- 
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/