linux-kernel - Re: [PATCH] drm/radeon/kms: crtc_ omitted in display assignments in radeon_atom_mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 15 Jan 2010 09:27:12 -0500
From:	Alex Deucher <alexdeucher@...il.com>
To:	Roel Kluin <roel.kluin@...il.com>
Cc:	David Airlie <airlied@...ux.ie>, dri-devel@...ts.sourceforge.net,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/radeon/kms: crtc_ omitted in display assignments in 
	radeon_atom_mode_fixup()?

On Fri, Jan 15, 2010 at 9:11 AM, Roel Kluin <roel.kluin@...il.com> wrote:
> The crtc_ prefix was omitted in h/vdisplay assignments
>
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>
> ---
> Not sure, but maybe the change below is needed? please ack/nack.

NAK.  the code is correct as is.

>
> diff --git a/drivers/gpu/drm/radeon/radeon_encoders.c b/drivers/gpu/drm/radeon/radeon_encoders.c
> index 82eb551..a9dc073 100644
> --- a/drivers/gpu/drm/radeon/radeon_encoders.c
> +++ b/drivers/gpu/drm/radeon/radeon_encoders.c
> @@ -233,8 +233,8 @@ static bool radeon_atom_mode_fixup(struct drm_encoder *encoder,
>                if (!ASIC_IS_AVIVO(rdev)) {
>                        adjusted_mode->hdisplay = mode->hdisplay;
>                        adjusted_mode->vdisplay = mode->vdisplay;
> -                       adjusted_mode->crtc_hdisplay = mode->hdisplay;
> -                       adjusted_mode->crtc_vdisplay = mode->vdisplay;
> +                       adjusted_mode->crtc_hdisplay = mode->crtc_hdisplay;
> +                       adjusted_mode->crtc_vdisplay = mode->crtc_vdisplay;
>                }
>                adjusted_mode->base.id = mode_id;
>        }
>
> ------------------------------------------------------------------------------
> Throughout its 18-year history, RSA Conference consistently attracts the
> world's best and brightest in the field, creating opportunities for Conference
> attendees to learn about information security's most important issues through
> interactions with peers, luminaries and emerging and established companies.
> http://p.sf.net/sfu/rsaconf-dev2dev
> --
> _______________________________________________
> Dri-devel mailing list
> Dri-devel@...ts.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/dri-devel
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/