linux-kernel - Re: [PATCH 1/4] kernel/kfifo.c: fix "interger as NULL pointer" warning.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 24 Jan 2010 18:15:24 +0100
From:	Stefani Seibold <stefani@...bold.net>
To:	Thiago Farina <tfransosi@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Andi Kleen <ak@...ux.intel.com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Mauro Carvalho Chehab <mchehab@...hat.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] kernel/kfifo.c: fix "interger as NULL pointer"
 warning.

Am Sonntag, den 24.01.2010, 11:03 -0500 schrieb Thiago Farina:
> kernel/kfifo.c:83:35: warning: Using plain integer as NULL pointer
> 

I don't know where you get this kind of warning. But passing 0 for a
NULL pointer is ANSI C standard.

> Signed-off-by: Thiago Farina <tfransosi@...il.com>
> ---
>  kernel/kfifo.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/kernel/kfifo.c b/kernel/kfifo.c
> index 32c5c15..6fe4a56 100644
> --- a/kernel/kfifo.c
> +++ b/kernel/kfifo.c
> @@ -80,7 +80,7 @@ int kfifo_alloc(struct kfifo *fifo, unsigned int size, gfp_t gfp_mask)
>  
>  	buffer = kmalloc(size, gfp_mask);
>  	if (!buffer) {
> -		_kfifo_init(fifo, 0, 0);
> +		_kfifo_init(fifo, NULL, 0);
>  		return -ENOMEM;
>  	}
>  


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/