lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 26 Jan 2010 11:24:47 +0800 From: Lai Jiangshan <laijs@...fujitsu.com> To: Frederic Weisbecker <fweisbec@...il.com> CC: Steven Rostedt <rostedt@...dmis.org>, linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>, Andrew Morton <akpm@...ux-foundation.org> Subject: Re: [PATCH 4/6] tracing: Change trace_seq to use separate buffer Frederic Weisbecker wrote: > On Tue, Jan 19, 2010 at 03:34:16PM +0800, Lai Jiangshan wrote: >> @@ -3124,6 +3126,8 @@ waitagain: >> if (cnt >= PAGE_SIZE) >> cnt = PAGE_SIZE - 1; >> >> + trace_seq_reset(&iter->seq); >> + > > > > So we actually add a trace_seq_reset here. > This should have been in the first patch, which drops > the memset, and eventually modified here, just to avoid > breaking things in the middle of a patchset. > > Things were already broken though before the memset dropping > patch though in other ways, so it's not that important I guess... > > There is no trace_seq_reset() before this patch applied. trace_seq_init() in the first patch, has already reset it. Things are not broken by the first patch, if I did not misunderstand. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists