lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 28 Jan 2010 08:24:26 +0100 From: Pavel Machek <pavel@....cz> To: "Rick L. Vinyard, Jr." <rvinyard@...nmsu.edu> Cc: Jiri Kosina <jkosina@...e.cz>, Oliver Neukum <oliver@...kum.org>, linux-kernel@...r.kernel.org, felipe.balbi@...ia.com, jayakumar.lkml@...il.com, linux-fbdev@...r.kernel.org, krzysztof.h1@...pl, akpm@...ux-foundation.org, linux-usb@...r.kernel.org, linux-input@...r.kernel.org, dmitry.torokhov@...il.com Subject: Re: [PATCH] hid: Logitech G13 driver 0.0.4 Hi! > is because it appears there are two conditions that fb_sys_write() will > continue on to the copy_from_user() but still return an error code. In > these cases -EFBIG and -ENOSPEC are returned but it is possible the buffer > has still been modified. > > Again, like I said, I don't have a problem changing it. If it's wrong, > it's wrong no matter how many other drivers may take the same > approach. I believe it is wrong. > My intuition tells me it's wrong, but at the same time I'd like to know if > there's a reason behind the other drivers also ignoring the EFAULT. Or, > perhaps it simply started in one driver and everyone else patterned after > it just like I did the g13 driver. I guess it is indeed a copy&paste problem... -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists