linux-kernel - Re: [PATCH 1/3] softlockup: add sched_clock_tick() to avoid kernel warning on kgdb resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 29 Jan 2010 09:07:06 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Jason Wessel <jason.wessel@...driver.com>,
	Thomas Gleixner <tglx@...utronix.de>
Cc:	linux-kernel@...r.kernel.org, kgdb-bugreport@...ts.sourceforge.net,
	Dongdong Deng <Dongdong.Deng@...driver.com>,
	peterz@...radead.org
Subject: Re: [PATCH 1/3] softlockup: add sched_clock_tick() to avoid kernel
 warning on kgdb resume


* Jason Wessel <jason.wessel@...driver.com> wrote:

> @@ -118,6 +125,14 @@ void softlockup_tick(void)
>  	}
>  
>  	if (touch_ts == 0) {
> +		if (unlikely(per_cpu(softlock_touch_sync, this_cpu))) {
> +			/*
> +			 * If the time stamp was touched atomically
> +			 * make sure the scheduler tick is up to date.
> +			 */
> +			per_cpu(softlock_touch_sync, this_cpu) = false;
> +			sched_clock_tick();
> +		}
>  		__touch_softlockup_watchdog();
>  		return;

Shouldnt just all of touch_softlockup_watchdog() gain this new 
sched_clock_tick() call, instead of doing this ugly flaggery? Or would that 
lock up or misbehave in other ways in some cases?

That would also make the patch much simpler i guess, as we'd only have the 
chunk above.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/