lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 02 Feb 2010 18:02:01 -0800 From: Joe Perches <joe@...ches.com> To: Kevin Pedretti <ktpedre@...dia.gov> Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] seastar - SeaStar Ethernet driver (review comments addressed) On Tue, 2010-02-02 at 18:08 -0700, Kevin Pedretti wrote: > diff -uprN -X linux-2.6.32.7-vanilla/Documentation/dontdiff linux-2.6.32.7-vanilla/drivers/net/seastar/main.c linux-2.6.32.7/drivers/net/seastar/main.c > --- linux-2.6.32.7-vanilla/drivers/net/seastar/main.c 1969-12-31 17:00:00.000000000 -0700 > +++ linux-2.6.32.7/drivers/net/seastar/main.c 2010-02-02 17:52:31.000000000 -0700 [] > +static struct pending *alloc_tx_pending(struct ss_priv *ssp) > +{ > + struct pending *pending = ssp->tx_pending_free_list; > + if (!pending) > + return NULL; > + > + ssp->tx_pending_free_list = pending->next; > + pending->next = 0; kernel style doesn't like pointer assignments of 0. NULL is preferred. > + /* Squash broadcast packets, SeaStar doesn't support broadcast */ > + if (dest_lo_mac == 0xFF) { > + dev_err(&ssp->pdev->dev, "squashing broadcast packet."); > + return -1; > + } Presumably SeaStar doesn't support multicast either, so maybe: if (dest_low_mac & 0x01) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists