lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 06 Feb 2010 08:19:30 -0500 From: Steven Rostedt <rostedt@...dmis.org> To: Frederic Weisbecker <fweisbec@...il.com> Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...e.hu>, LKML <linux-kernel@...r.kernel.org>, Arnaldo Carvalho de Melo <acme@...hat.com>, Paul Mackerras <paulus@...ba.org>, Hitoshi Mitake <mitake@....info.waseda.ac.jp>, Li Zefan <lizf@...fujitsu.com>, Lai Jiangshan <laijs@...fujitsu.com>, Masami Hiramatsu <mhiramat@...hat.com>, Jens Axboe <jens.axboe@...cle.com> Subject: Re: [PATCH 02/11] tracing: Introduce TRACE_EVENT_INJECT On Sat, 2010-02-06 at 13:20 +0100, Frederic Weisbecker wrote: > I agree with you that creating a new trace event macro is a bit > insane. ftrace.h is already a nightmare. I just thought that > having the injector set inside the same macro that the synchronous > event is defined helped to make it clear about its nature: that > it needs a secondary async catch up thing. > > But a register_event_injector thing will work too, we probably > better want that, given the maintainance pain otherwise. We can add a register_event_injector later. For now, why not just add the TRACE_EVENT() and then hook to it in perf using the normal tracepoint mechanism. You could add some macro around the trace_init_lock_class() call that would facilitate finding all the locks you need. This would probably be a bit more straight forward than to overload TRACE_EVENT() again. > > I really would like to make something useful for everyone, could > you tell me more about johill needs? Well, basically he needed a way to cause polling to happen using an event. From what I understood, the polling called the trace point. Just enabling the trace point did nothing because the polling did not take place. I thought about ways to enable this command when the trace point was enabled. But in the end, it was specific to a driver and another debugfs file seemed a better fit to initiate it. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists