linux-kernel - [PATCH] security/integrity/ima/ima_iint.c: Remove goto out int ima_inode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 8 Feb 2010 14:57:28 +0800
From:	wzt wzt <wzt.wzt@...il.com>
To:	linux-kernel@...r.kernel.org
Cc:	zohar@...ibm.com
Subject: [PATCH] security/integrity/ima/ima_iint.c: Remove goto out int 
	ima_inode_alloc()

Signed-off-by: wzt <zhitong.wangzt@...baba-inc.com>

diff --git a/security/integrity/ima/ima_iint.c
b/security/integrity/ima/ima_iint.c
index 0d83edc..4e2df22 100644
--- a/security/integrity/ima/ima_iint.c
+++ b/security/integrity/ima/ima_iint.c
@@ -57,18 +57,17 @@ int ima_inode_alloc(struct inode *inode)
                return -ENOMEM;

        rc = radix_tree_preload(GFP_NOFS);
-       if (rc < 0)
-               goto out;
+       if (rc < 0) {
+               kmem_cache_free(iint_cache, iint);
+               radix_tree_preload_end();
+               return rc;
+       }

        spin_lock(&ima_iint_lock);
        rc = radix_tree_insert(&ima_iint_store, (unsigned long)inode, iint);
        spin_unlock(&ima_iint_lock);
-out:
-       if (rc < 0)
-               kmem_cache_free(iint_cache, iint);

        radix_tree_preload_end();
-
        return rc;
 }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/