lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 9 Feb 2010 14:27:25 +0800 From: Dave Young <hidave.darkstar@...il.com> To: Andrew Morton <akpm@...ux-foundation.org> Cc: linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu> Subject: Re: [PATCH 2/2] allow printk delay after multi lines On Tue, Feb 9, 2010 at 2:07 PM, Andrew Morton <akpm@...ux-foundation.org> wrote: > On Tue, 9 Feb 2010 13:56:34 +0800 Dave Young <hidave.darkstar@...il.com> wrote: > >> BTW, for the sysctl variables. I found in kernel.h there's: >> printk/console_loglevel/panic related extern variables for sysctl. >> >> console_loglevel and panic related variables are used here and there, >> not just for sysctl, so I think it should stay in kernel.h. >> >> The printk related variables for sysctl and all the extern variables in >> sysctl.c can be move to sysctl.h. Seems no need new head file. >> >> Andrew, what's your opinion? > > Symbols which are defined in printk.c and which are used in other > compilation units should be declared in printk.h! > > We mucked up in the past by putting these things in kernel.h and as > externs in sysctl.c, but that's no reason to continue to do so. As a > special-case, it makes convenience sense to declare printk() itself and > the loglevel strings etc in kernel.h, but that _is_ a special case. > Lazy is bad, hehe :) Will do that in a updated patchset, Thanks. -- Regards dave -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists