linux-kernel - Re: [PATCH] nl80211: does not allow NEW_STATION and DEL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 12 Feb 2010 11:55:36 -0200
From:	Thadeu Lima de Souza Cascardo <cascardo@...oscopio.com>
To:	Johannes Berg <johannes@...solutions.net>
Cc:	linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
	Simon Raffeiner <sturmflut@...berbiber.de>,
	Andrey Yurovsky <andrey@...ybit.com>,
	Javier Cardona <javier@...ybit.com>
Subject: Re: [PATCH] nl80211: does not allow NEW_STATION and DEL_STATION
 for mesh

On Fri, Feb 12, 2010 at 01:49:53PM +0100, Johannes Berg wrote:
> On Fri, 2010-02-12 at 10:37 -0200, Thadeu Lima de Souza Cascardo wrote:
> > As discussed in linux-wireless mailint list, adding and removing
> > stations for mesh topologies is not necessary. Since doing it triggers
> > bugs, the sugestion was to simply disable it.
> > 
> > Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@...oscopio.com>
> > Cc: Johannes Berg <johannes@...solutions.net>
> > Cc: Simon Raffeiner <sturmflut@...berbiber.de>
> > Cc: Andrey Yurovsky <andrey@...ybit.com>
> > Cc: Javier Cardona <javier@...ybit.com>
> > ---
> >  net/wireless/nl80211.c |   47
> > +++++++++++------------------------------------
> >  1 files changed, 11 insertions(+), 36 deletions(-)
> > 
> > diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
> > index 5b79ecf..176b8fe 100644
> > --- a/net/wireless/nl80211.c
> > +++ b/net/wireless/nl80211.c
> > @@ -2001,6 +2001,10 @@ static int nl80211_new_station(struct sk_buff
> > *skb, struct genl_info *info)
> >  
> >  	memset(&params, 0, sizeof(params));
> >  
> > +	if (dev->ieee80211_ptr->iftype != NL80211_IFTYPE_AP &&
> > +	    dev->ieee80211_ptr->iftype != NL80211_IFTYPE_AP_VLAN)
> > +		return -EINVAL;
> > +
> >  	if (!info->attrs[NL80211_ATTR_MAC])
> >  		return -EINVAL;
> 
> You clearly didn't ever try this code.
> 
> johannes

Sorry. This code has obviously given me an oops. I did it in a hurry and
thought that was a good optimization to get out as early as possible in
the case the device was not in AP mode.

I have fixed it, but I would like to do a more thorough test now to make
up for my mistake.

So, is there any test tool around? I am playing with iw code to do
these tests. Any recommendations for the values of listen interval and
the acceptable values for supported rates and aid?

Regards,
Cascardo.

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)