linux-kernel - <linux/wait.h> requires <linux/sched.h> (was Re: [PATCH 3/4] firewire: get_cycle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 20 Feb 2010 22:24:43 +0100 (CET)
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	linux-kernel@...r.kernel.org
cc:	linux1394-devel@...ts.sourceforge.net
Subject: <linux/wait.h> requires <linux/sched.h> (was Re: [PATCH 3/4]
 firewire: get_cycle_timer optimization and cleanup)

On 14 Feb, Stefan Richter wrote:
> --- linux-2.6.33-rc8.orig/drivers/firewire/core-cdev.c
> +++ linux-2.6.33-rc8/drivers/firewire/core-cdev.c
[...]
> @@ -32,8 +33,6 @@
>  #include <linux/module.h>
>  #include <linux/mutex.h>
>  #include <linux/poll.h>
> -#include <linux/preempt.h>
> -#include <linux/sched.h>
>  #include <linux/spinlock.h>
>  #include <linux/string.h>
>  #include <linux/time.h>
[...]

This doesn't compile on some configurations.  core-cdev.c requires (and
includes) linux/wait.h which in turn requires (but does not include)
linux/sched.h.

However, adding #include <linux/sched.h> in wait.h isn't going to be
possible very easily; there are a whole lot of missing definitions in
other headers that are pulled in by sched.h then.

Hence I will simply readd sched.h to firewire/core-cdev.c.
-- 
Stefan Richter
-=====-==-=- --=- =-=--
http://arcgraph.de/sr/

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/