linux-kernel - Re: [REGRESSION] "USB: use kfifo to buffer usb-generic serial writes" causes gobi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 22 Feb 2010 14:10:33 -0500 (EST)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Anssi Hannula <anssi.hannula@....fi>
cc:	Oliver Neukum <oliver@...kum.org>,
	Matthew Garrett <mjg59@...f.ucam.org>, <dvomlehn@...co.com>,
	<gregkh@...e.de>, <linux-usb@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [REGRESSION] "USB: use kfifo to buffer usb-generic serial writes"
 causes gobi_loader to hang

On Mon, 22 Feb 2010, Anssi Hannula wrote:

> I guess that would suggest that the device doesn't allow the initialization 
> data to be broken into packets arbitrarily (though some differences seem 
> allowed, as the windows driver transmits them differently).
> 
> Does this mean a tty interface is ill-suited for the microcode upload, and 
> instead qcserial should use the kernel's generic microcode upload mechanism or 
> the userspace should use libusb to do it?

I don't know.  Didn't the old successful code use a tty interface?

> Any idea what could be causing the hang, then?

No idea, unless it's the device.

>  The WARNING that appears when 
> interrupting the hung gobi_loader is for serial_unthrottle() being called 
> while usb_serial_port->port.count == 0.

That's a bogus warning.  It will be removed in an upcoming kernel 
version.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/