linux-kernel - Re: [PATCH 0/6] Fix file descriptor leak on user-space processes and cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 25 Feb 2010 12:52:45 -0300
From:	André Goddard Rosa <andre.goddard@...il.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	"Serge E . Hallyn" <serue@...ibm.com>,
	Cedric Le Goater <clg@...ibm.com>,
	Al Viro <viro@...iv.linux.org.uk>,
	linux-kernel@...r.kernel.org, stable@...nel.org
Subject: Re: [PATCH 0/6] Fix file descriptor leak on user-space processes and 
	cleanup

Hi, Andrew!

On Wed, Feb 24, 2010 at 7:01 PM, Andrew Morton
<akpm@...ux-foundation.org> wrote:
> On Tue, 23 Feb 2010 04:04:22 -0300 Andr__ Goddard Rosa <andre.goddard@...il.com> wrote:
>
>> Fix a file descriptor leak on user-space processes and perform a cleanup,
>> reducing the code size:
>> text    data     bss     dec     hex filename
>> 9949      72      16   10037    2735 ipc/mqueue-BEFORE.o
>> 9885      72      16    9973    26f5 ipc/mqueue-AFTER.o
>>
>> Andr__ Goddard Rosa (6):
>>   mqueue: remove unneeded info->messages initialization
>>   mqueue: apply mathematics distributivity on mq_bytes calculation
>>   mqueue: simplify do_open() error handling
>>   mqueue: only set error codes if they are really necessary
>>   mqueue: fix typo "failues" -> "failures"
>>   mqueue: fix mq_open() file descriptor leak on user-space processes
>
> Fixing the leak is far more important than the other five patches, and
> we'll want to backport the leak fix into earlier kernels.  So the
> bugfix patch should have been the first in the series!

Sure, thank you for that, I'll consider your good advice.

> So I've reordered the patches in that fashion and shall tag "mqueue:
> fix mq_open() file descriptor leak on user-space processes" as needing
> -stable backporting.
>
> The patches apply and build OK with that reordering, but please do
> double-check it, thanks.
>

I have double checked and they look good; thanks for the follow-up
patch pleasing checkpatch.
:)

Do I need to send another patch adding the Acked-by's or is it done by
email system automatically?

Best regards,
André
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/