linux-kernel - Re: [PATCH 1/8] p9auth: set fsuid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 25 Feb 2010 21:06:39 -0800
From:	Greg KH <greg@...ah.com>
To:	"Serge E. Hallyn" <serue@...ibm.com>
Cc:	rsc@...ch.com, Ashwin Ganti <ashwin.ganti@...il.com>,
	ericvh@...il.com, devel@...uxdriverproject.org,
	linux-kernel@...r.kernel.org, Ron Minnich <rminnich@...il.com>,
	jt.beard@...il.com
Subject: Re: [PATCH 1/8] p9auth: set fsuid

On Thu, Feb 25, 2010 at 10:05:53PM -0600, Serge E. Hallyn wrote:
> Quoting Greg KH (greg@...ah.com):
> > On Tue, Feb 16, 2010 at 04:44:54PM -0600, Serge Hallyn wrote:
> > > From: Serge E. Hallyn <serue@...ibm.com>
> > > 
> > > fsuid should always trail euid changes.  So p9auth should
> > > set fsuid as well when it sets ruid and euid.  Whether the
> > > suid should also be set is an open question - keeping the
> > > old uid in suid may be useful, or may just serve to trick
> > > lazy userspace.
> > > 
> > > Note that so long as we do not also set suid, the setuid_fixup()
> > > code will not (when we later switch to setresuid()) fully
> > > fill/clear capability sets.  So while I had previously thought
> > > that keeping suid unchanged would be useful, I think it is
> > > better to change all uids.
> 
> Hi Greg,
> 
> > What is your goal for the p9auth code?  Currently it is deleted in
> > linux-next due to a lack of development.  I see you have some cleanup
> > patches, but I can't apply them unless you get the non-staging patches
> > accepted.
> 
> Sorry, what do you mean by 'the non-staging patches'?  Do you mean
> the staging patches that were dropped, the cleanup patches (that
> wouldn't make sense), or another set of patches?

I mean the ones that were not for the drivers/staging/p9auth/ directory.
I can't apply patches to the staging git tree for stuff outside of
drivers/staging/

> > If I bring the driver back from deletion, will you work to fix it up and
> > get it merged into mainline?
> 
> Yes.

Great.

> > What's the word on the non-staging patches in this series being
> > accepted?
> 
> Again, I'm not quite sure which you mean by the non-staging patches,
> or what you mean by accepted - do you mean general community acceptance
> of the base p9auth patches, or acceptance of my p9uath patches by
> Ashwin etc?

Well. I was referring to the patches outside of the drivers/staging/
directory, but also, it would be good to see if Ashwin has any
objections to them.

Once you two work it out, care to resend them?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/