linux-kernel - Re: [PATCH] Driver core: Reduce the level of request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 28 Feb 2010 10:13:29 +0530
From:	Jaswinder Singh Rajput <jaswinderlinux@...il.com>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	Greg KH <gregkh@...e.de>, LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	David Woodhouse <dwmw2@...radead.org>
Subject: Re: [PATCH] Driver core: Reduce the level of request_firmware() 
	messages

Hello Rafael,

On Sun, Feb 28, 2010 at 2:13 AM, Rafael J. Wysocki <rjw@...k.pl> wrote:
> From: Rafael J. Wysocki <rjw@...k.pl>
>
> The messages from _request_firmware() informing that firmware is
> being requested or built-in firmware is going to be used are printed
> at KERN_INFO, which produces lots of noise on systems with huge
> numbers of AMD CPUs.  Reduce the level of these messages to
> KERN_DEBUG to get rid of that noise.
>

Which firmware we are using is very useful information. Because of
huge numbers of CPUs it seems noise then better provide the
information for first cpu and for the rest of the CPUs you can show by
KERN_DEBUG.

Thanks,
--
Jaswinder Singh.

> Signed-off-by: Rafael J. Wysocki <rjw@...k.pl>
> ---
>  drivers/base/firmware_class.c |    5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> Index: linux-2.6.32-SLE11-SP1/drivers/base/firmware_class.c
> ===================================================================
> --- linux-2.6.32-SLE11-SP1.orig/drivers/base/firmware_class.c
> +++ linux-2.6.32-SLE11-SP1/drivers/base/firmware_class.c
> @@ -487,15 +487,14 @@ _request_firmware(const struct firmware
>             builtin++) {
>                if (strcmp(name, builtin->name))
>                        continue;
> -               dev_info(device, "firmware: using built-in firmware %s\n",
> -                        name);
> +               dev_dbg(device, "firmware: using built-in firmware %s\n", name);
>                firmware->size = builtin->size;
>                firmware->data = builtin->data;
>                return 0;
>        }
>
>        if (uevent)
> -               dev_info(device, "firmware: requesting %s\n", name);
> +               dev_dbg(device, "firmware: requesting %s\n", name);
>
>        retval = fw_setup_device(firmware, &f_dev, name, device, uevent);
>        if (retval)
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/