linux-kernel - Re: [PATCH] block: don't access jiffies when initialising io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 1 Mar 2010 10:56:56 +0100
From:	Jens Axboe <jens.axboe@...cle.com>
To:	Richard Kennedy <richard@....demon.co.uk>
Cc:	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] block: don't access jiffies when initialising
	io_context

On Mon, Mar 01 2010, Richard Kennedy wrote:
> As the comment says the initial value of last_waited is never used, so
> there is no need to initialise it with the current jiffies. Jiffies is
> hot enough without accessing it for no reason.

Applied, though it will not make a huge difference in any way.
alloc_io_context() only gets called the first time a process does IO, so
it's not a hot path.

> 
> Signed-off-by: Richard Kennedy <richard@....demon.co.uk>
> ---
> patch against 2.6.33
> compiled & tested on x86_64
> 
> diff --git a/block/blk-ioc.c b/block/blk-ioc.c
> index 98e6bf6..3f65c8a 100644
> --- a/block/blk-ioc.c
> +++ b/block/blk-ioc.c
> @@ -91,7 +91,7 @@ struct io_context *alloc_io_context(gfp_t gfp_flags, int node)
>  		spin_lock_init(&ret->lock);
>  		ret->ioprio_changed = 0;
>  		ret->ioprio = 0;
> -		ret->last_waited = jiffies; /* doesn't matter... */
> +		ret->last_waited = 0; /* doesn't matter... */
>  		ret->nr_batch_requests = 0; /* because this is 0 */
>  		INIT_RADIX_TREE(&ret->radix_root, GFP_ATOMIC | __GFP_HIGH);
>  		INIT_HLIST_HEAD(&ret->cic_list);
> 
> 

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/