| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 1 Mar 2010 11:52:08 +0100 From: Jan Kara <jack@...e.cz> To: Akinobu Mita <akinobu.mita@...il.com> Cc: Jan Kara <jack@...e.cz>, linux-kernel@...r.kernel.org Subject: Re: [PATCH] udf: use ext2_find_next_bit On Thu 25-02-10 10:38:25, Akinobu Mita wrote: > 2010/2/25 Jan Kara <jack@...e.cz>: > > On Tue 23-02-10 23:11:13, Akinobu Mita wrote: > >> Use ext2_find_next_bit (generic_find_next_le_bit) to find the set bit > >> in little endian bitmap region. > >> > >> Signed-off-by: Akinobu Mita <akinobu.mita@...il.com> > >> Cc: Jan Kara <jack@...e.cz> > > I've looked at the code and I think this is wrong. UDF uses 1 for free > > block in the bitmap and 0 for used one. So you need to use > > generic_find_next_le_bit... > > Something like the patch below? > > According to include/asm-generic/bitops/ext2-non-atomic.h, > generic_find_next_le_bit() == ext2_find_next_bit(). Ah, I'm really sorry. I've originally misread the header and thought that ext2_find_next_bit == generic_find_next_le_zero_bit. So my patch does exactly the same thing as yours. I've now merged your patch so that you get proper credit. > BTW, I realized that udf_find_first_one_bit() macro is not used. > So you can remove it in this patch. Yes, I've removed it now. Honza -- Jan Kara <jack@...e.cz> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists