linux-kernel - Re: [PATCH 61/62] msi-laptop: depends on RFKILL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 2 Mar 2010 22:09:56 -0800
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Greg Kroah-Hartman <gregkh@...e.de>
Cc:	linux-kernel@...r.kernel.org,
	Randy Dunlap <randy.dunlap@...cle.com>,
	Lennart Poettering <mzxreary@...inter.de>,
	"Lee, Chun-Yi" <jlee@...ell.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 61/62] msi-laptop: depends on RFKILL

On Tue, Mar 02, 2010 at 03:29:00PM -0800, Greg Kroah-Hartman wrote:
> From: Randy Dunlap <randy.dunlap@...cle.com>
> 
> msi-laptop uses rfkill*() interfaces so it should depend on RFKILL.
> 
> msi-laptop.c:(.text+0x1fcd1b): undefined reference to `rfkill_alloc'
> msi-laptop.c:(.text+0x1fcd76): undefined reference to `rfkill_register'
> msi-laptop.c:(.text+0x1fcdc8): undefined reference to `rfkill_destroy'
> msi-laptop.c:(.text+0x1fcdd9): undefined reference to `rfkill_unregister'
> 
> This repairs "msi-laptop: Detect 3G device exists by standard ec command",
> which is in some gregkh tree.
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
> Cc: Lennart Poettering <mzxreary@...inter.de>
> Cc: Lee, Chun-Yi <jlee@...ell.com>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de>
> ---
>  drivers/platform/x86/Kconfig |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 6848f21..d911de3 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -148,6 +148,7 @@ config MSI_LAPTOP
>  	tristate "MSI Laptop Extras"
>  	depends on ACPI
>  	depends on BACKLIGHT_CLASS_DEVICE
> +	depends on RFKILL

I must say I really dislike when "depends" is used with drivers like
this for high-level subsystems. How would a user (advanced, I agree)
know about existence of such a driver when doing make oldconfig unless
he examines entirety of the pull (new rc patch, tarball, whatever)? And
even if he is aware of the new driver he needs to know exact config name
to see the dependencies (even if he knows how)...

We all know dangers of "select" but I think it is useful when used
judiciously, for entire subsystems only (like selecting serio,
backlight, leds, etc) that do not have additional dependencies.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/