linux-kernel - Re: [PATCH 6/6] staging:et131x:et131x_isr.c Fix coding style issues. This patch fixes line length and brace coding style issues raised by checkpatch.pl Signed-off-by: Michael Tate <michael.tate@...adoo.fr>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 5 Mar 2010 14:55:23 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Michael Tate <michael.tate@...adoo.fr>
Cc:	gregkh@...e.de, alan@...ux.intel.com, o.hartmann@...ovital.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/6] staging:et131x:et131x_isr.c Fix coding style
 issues. This patch fixes line length and brace coding style issues raised
 by checkpatch.pl Signed-off-by: Michael Tate <michael.tate@...adoo.fr>

> -	if (status & ET_INTR_TXDMA_ISR) {
> +	if (status & ET_INTR_TXDMA_ISR)
>  		et131x_handle_send_interrupt(etdev);
> -	}
>  
>  	/* Handle all the completed Receives interrupts */
> -	if (status & ET_INTR_RXDMA_XFR_DONE) {
> +	if (status & ET_INTR_RXDMA_XFR_DONE)
>  		et131x_handle_recv_interrupt(etdev);
> -	}

Plenty of those to kill I am sure. 


>  		/* Handle Free Buffer Ring 0 and 1 Low interrupt */
> -		if (status & (ET_INTR_RXDMA_FB_R0_LOW | ET_INTR_RXDMA_FB_R1_LOW)) {
> +		if (status &
> +			(ET_INTR_RXDMA_FB_R0_LOW | ET_INTR_RXDMA_FB_R1_LOW)) {

Bt gratuitious wrapping of stuff that's quite readable is not an
improvement. (The 80 chars guide in the coding style is just that - and
largely retired)

>  			/*
>  			 * This indicates the number of unused buffers in
>  			 * RXDMA free buffer ring 0 is <= the limit you

You need a Signed-off-by: line for submitting it. See
Documentation/SubmittingPatches for more details if you need to.

Please do resubit the first parts of that patch (and others like it), the
driver still needs a lot of attention and cleaning it up stylewise is
part of that work.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/