linux-kernel - Re: [PATCH 04/11] ST SPEAr: Added basic header files for SPEAr platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 10 Mar 2010 10:31:18 +0100
From:	Linus Walleij <linus.ml.walleij@...il.com>
To:	Viresh KUMAR <viresh.kumar@...com>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	armando.visconti@...com, amit.goel@...com, shiraz.hashim@...com,
	vipin.kumar@...com, rajeev-dlh.kumar@...com, deepak.sikri@...com,
	ashish.priyadarshi@...com
Subject: Re: [PATCH 04/11] ST SPEAr: Added basic header files for SPEAr 
	platform

2010/3/10 Viresh KUMAR <viresh.kumar@...com>:
> Linus Walleij:
>> If this file is only supposed to be used from plat-spear/time.c, move it down
>> into plat-spear/gpt.h and #include "gpt.h" so noone else will
>> accidentally use it.
>
> GPT's on SPEAr can be used from time.c, platform specific drivers and machine
> specific drivers or any driver wishing to use hardware timer.
> In first two cases "gpt.h" will work, but in rest of cases we need gpt.h to be
> in plat-spear/include/plat
>
> Is it okay?

If you have or have already planned to write such platform, machine
or subsystem drivers, it's OK, if there are no such users and you cannot
easily give one, it's overdesigned IMHO. Some realistic examples of such
drivers will make me change my mind :-)

The reason I persist is that I've seen such unutilized timer API:s before and
no other user than the system timer in sight. I never understood what they
were to be used for, and I still don't, so help me understand. The kernel
has many internal timer API:s based on clockevent available already so
why add yet another, platform-specific one?

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/